Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing and build fixes to benchmarking #909

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Typing and build fixes to benchmarking #909

merged 7 commits into from
Jan 2, 2025

Conversation

tp832944
Copy link
Contributor

@tp832944 tp832944 commented Dec 24, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Refactoring (no functional changes)
  • Build related changes
  • Documentation content changes

Description

Add extra dependencies to benchmark in pyproject.toml to match what scripts require.

Add example dependency group.

Additional typing and refactoring in benchmark scripts. No idea how the original worked! This should be clearer and pass pyright.

Works towards but does not close #744.

How Has This Been Tested?

Existing tests pass as expected.

pylint passes. Unchecked on pyright.

Does this PR introduce a breaking change?

No.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@tp832944
fix: move some dependencies from test to also include benchmark
21b9698 
imageio, matplotlib, numpy
@tp832944
fix: refactor benchmarking solver setup to avoid magic
6268fb4 
Not sure why it was working, but was definitely no good for a type checker.

Use absolute imports in benchmarking.

refs: #744
@tp832944 tp832944 requested a review from qh681248 December 24, 2024 15:14
@tp832944 tp832944 self-assigned this Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 2f6d852 - Merge 6268fb4 into 4252551

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit cc9096c - Merge 9941d04 into 4252551

No significant changes to performance.

qh681248
qh681248 reviewed Jan 2, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Performance review

Commit 9a8365d - Merge 5a38251 into 89528be

No significant changes to performance.

@tp832944 tp832944 requested a review from qh681248 January 2, 2025 12:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Performance review

Commit 527447d - Merge 236d05f into 89528be

No significant changes to performance.

qh681248
qh681248 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@qh681248 qh681248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with all the changes

@qh681248 qh681248 merged commit 770ed2a into main Jan 2, 2025
19 checks passed
@qh681248 qh681248 deleted the fix/pyright3 branch January 2, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qh681248 qh681248 qh681248 approved these changes

Assignees

@tp832944 tp832944

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix static type checker complaints for main package
2 participants
@tp832944 @qh681248